commit 1b4ccf1ed5c6369e1b4ddde0ced9583b403e1c01
author Wenyi Wang <wenyiw@google.com> Fri Nov 13 14:00:09 2015 -0800
committer Wenyi Wang <wenyiw@google.com> Fri Nov 13 14:00:09 2015 -0800
tree 67fa89daeb3ab3d9569a921b89855a0f4fdb1350
parent df864c7808e84ad7938af5e1b5246f1b17673326

Add editor for visible valuesDeltas

Bug: 25690715
Change-Id: Id5438976fa7e4c0d31d0fbbdd0b40df361b72668

src/com/android/contacts/editor/CompactKindSectionView.java

diff --git a/src/com/android/contacts/editor/CompactKindSectionView.java b/src/com/android/contacts/editor/CompactKindSectionView.java
index b4ee2bb..c1e659f 100644
--- a/src/com/android/contacts/editor/CompactKindSectionView.java
+++ b/src/com/android/contacts/editor/CompactKindSectionView.java
@@ -330,7 +330,7 @@
                 } else {
                     editorListener = new NonNameEditorListener();
                 }
-                for (ValuesDelta valuesDelta : kindSectionData.getVisibleNonEmptyValuesDeltas()) {
+                for (ValuesDelta valuesDelta : kindSectionData.getVisibleValuesDeltas()) {
                     addNonNameEditorView(kindSectionData.getRawContactDelta(),
                             kindSectionData.getDataKind(), valuesDelta, editorListener);
                 }

src/com/android/contacts/editor/KindSectionData.java

diff --git a/src/com/android/contacts/editor/KindSectionData.java b/src/com/android/contacts/editor/KindSectionData.java
index 341669a..bd9f687 100644
--- a/src/com/android/contacts/editor/KindSectionData.java
+++ b/src/com/android/contacts/editor/KindSectionData.java
@@ -53,12 +53,12 @@
         return valuesDeltas == null ? new ArrayList<ValuesDelta>() : valuesDeltas;
     }
 
-    /** Returns visible and non empty ValuesDeltas for the data kind this section represents. */
-    public List<ValuesDelta> getVisibleNonEmptyValuesDeltas() {
+    /** Returns visible and non no-op ValuesDeltas for the data kind this section represents. */
+    public List<ValuesDelta> getVisibleValuesDeltas() {
         final ArrayList<ValuesDelta> valuesDeltas = new ArrayList<> ();
         for (ValuesDelta valuesDelta : getValuesDeltas()) {
             // Same conditions as KindSectionView#rebuildFromState
-            if (valuesDelta.isVisible() && !valuesDelta.isNoop() && !isEmpty(valuesDelta)) {
+            if (valuesDelta.isVisible() && !valuesDelta.isNoop()) {
                 valuesDeltas.add(valuesDelta);
             }
         }