commit 09a33b4056235885f330a3312afd059dc8465f6d
author Daisuke Miyakawa <dmiyakawa@google.com> Fri Jul 22 17:31:43 2011 -0700
committer Daisuke Miyakawa <dmiyakawa@google.com> Fri Jul 22 18:33:17 2011 -0700
tree d267f5ff9a3b56bfda7d3e9eac287c164729a948
parent 402d5c9ccd5d07aca67618de76ddf24d1a9a0e46

Remove illegal state exception entirely

There's no easy way to tell if the id is invalid or not, as the
id may come from outside the fragment if we're using ViewPager.

DialpadFragment on the other hand ignores unknown ids. Let's ignore
it here too.

Bug: 5067067
Change-Id: I7b4ef764beca526baf6d72d47ca5d4d0094e32e9

src/com/android/contacts/calllog/CallLogFragment.java

diff --git a/src/com/android/contacts/calllog/CallLogFragment.java b/src/com/android/contacts/calllog/CallLogFragment.java
index f83938a..9f64815 100644
--- a/src/com/android/contacts/calllog/CallLogFragment.java
+++ b/src/com/android/contacts/calllog/CallLogFragment.java
@@ -1012,12 +1012,8 @@
                 mCallLogQueryHandler.fetchVoicemailOnly();
                 return true;
             }
-            case R.id.menu_call_settings_call_log: {
-                // Intent is already set.
-                return false;
-            }
             default:
-                throw new IllegalArgumentException("unknown menu item: " + item.getItemId());
+                return false;
         }
     }
 

src/com/android/contacts/dialpad/DialpadFragment.java

diff --git a/src/com/android/contacts/dialpad/DialpadFragment.java b/src/com/android/contacts/dialpad/DialpadFragment.java
index 717db46..6acbc85 100644
--- a/src/com/android/contacts/dialpad/DialpadFragment.java
+++ b/src/com/android/contacts/dialpad/DialpadFragment.java
@@ -1143,8 +1143,9 @@
             case R.id.menu_add_wait:
                 updateDialString(";");
                 return true;
+            default:
+                return false;
         }
-        return false;
     }
 
     @Override