commit 025838f0a4b7c19640035a89d42512b892c503ba
author Dmitri Plotnikov <dplotnikov@google.com> Wed Sep 22 17:52:42 2010 -0700
committer Dmitri Plotnikov <dplotnikov@google.com> Wed Sep 22 17:52:42 2010 -0700
tree d0e069652a76c80abac8dd21571ce64aa65691a5
parent 59f73b2c61736d509d3ad5576d007bcbdca1335e

Fixing NPE in Group Selector UI

Also making My Contacts preselected and not uncheckable
for new contacts in accounts with a default group.

Bug: 3024875
Change-Id: I068f10d227b11aa6b47c85bd5d3ba4b71c011c58

src/com/android/contacts/ui/widget/GroupMembershipView.java

diff --git a/src/com/android/contacts/ui/widget/GroupMembershipView.java b/src/com/android/contacts/ui/widget/GroupMembershipView.java
index 2181851..572b204 100644
--- a/src/com/android/contacts/ui/widget/GroupMembershipView.java
+++ b/src/com/android/contacts/ui/widget/GroupMembershipView.java
@@ -82,6 +82,7 @@
     private String mAccountType;
     private TextView mGroupList;
     private ArrayAdapter<GroupSelectionItem> mAdapter;
+    private long mDefaultGroupId;
     private long mFavoritesGroupId;
     private ListPopupWindow mPopup;
     private DataKind mKind;
@@ -107,8 +108,9 @@
 
     public void setState(EntityDelta state) {
         mState = state;
-        mAccountType = state.getValues().getAsString(RawContacts.ACCOUNT_TYPE);
-        mAccountName = state.getValues().getAsString(RawContacts.ACCOUNT_NAME);
+        ValuesDelta values = state.getValues();
+        mAccountType = values.getAsString(RawContacts.ACCOUNT_TYPE);
+        mAccountName = values.getAsString(RawContacts.ACCOUNT_NAME);
         updateView();
     }
 
@@ -120,6 +122,9 @@
         }
 
         boolean accountHasGroups = false;
+        mFavoritesGroupId = 0;
+        mDefaultGroupId = 0;
+
         StringBuilder sb = new StringBuilder();
         mGroupMetaData.moveToPosition(-1);
         while (mGroupMetaData.moveToNext()) {
@@ -130,6 +135,9 @@
                 if (!mGroupMetaData.isNull(GroupMetaDataLoader.FAVORITES)
                         && mGroupMetaData.getInt(GroupMetaDataLoader.FAVORITES) != 0) {
                     mFavoritesGroupId = groupId;
+                } else if (!mGroupMetaData.isNull(GroupMetaDataLoader.AUTO_ADD)
+                            && mGroupMetaData.getInt(GroupMetaDataLoader.AUTO_ADD) != 0) {
+                    mDefaultGroupId = groupId;
                 } else {
                     accountHasGroups = true;
                 }
@@ -145,6 +153,8 @@
             }
         }
 
+        // Only show the default group for existing contacts (not for inserts)
+        accountHasGroups |= (!mState.isContactInsert() && mDefaultGroupId != 0);
         if (!accountHasGroups) {
             setVisibility(GONE);
             return;
@@ -175,7 +185,15 @@
             String accountType = mGroupMetaData.getString(GroupMetaDataLoader.ACCOUNT_TYPE);
             if (accountName.equals(mAccountName) && accountType.equals(mAccountType)) {
                 long groupId = mGroupMetaData.getLong(GroupMetaDataLoader.GROUP_ID);
-                if (groupId != mFavoritesGroupId) {
+                boolean showGroup;
+                if (groupId == mFavoritesGroupId) {
+                    showGroup = false;
+                } else if (groupId == mDefaultGroupId) {
+                    showGroup = !mState.isContactInsert();
+                } else {
+                    showGroup = true;
+                }
+                if (showGroup) {
                     String title = mGroupMetaData.getString(GroupMetaDataLoader.TITLE);
                     boolean checked = hasMembership(groupId);
                     mAdapter.add(new GroupSelectionItem(groupId, title, checked));
@@ -218,9 +236,12 @@
         ArrayList<ValuesDelta> entries = mState.getMimeEntries(GroupMembership.CONTENT_ITEM_TYPE);
         if (entries != null) {
             for (ValuesDelta entry : entries) {
-                long groupId = entry.getAsLong(GroupMembership.GROUP_ROW_ID);
-                if (groupId != mFavoritesGroupId && !isGroupChecked(groupId)) {
-                    entry.markDeleted();
+                if (!entry.isDelete()) {
+                    Long groupId = entry.getAsLong(GroupMembership.GROUP_ROW_ID);
+                    if (groupId != null && groupId != mFavoritesGroupId
+                            && !isGroupChecked(groupId)) {
+                        entry.markDeleted();
+                    }
                 }
             }
         }
@@ -250,11 +271,18 @@
     }
 
     private boolean hasMembership(long groupId) {
+        if (groupId == mDefaultGroupId && mState.isContactInsert()) {
+            return true;
+        }
+
         ArrayList<ValuesDelta> entries = mState.getMimeEntries(GroupMembership.CONTENT_ITEM_TYPE);
         if (entries != null) {
             for (ValuesDelta values : entries) {
-                if (values.getAsLong(GroupMembership.GROUP_ROW_ID) == groupId) {
-                    return true;
+                if (!values.isDelete()) {
+                    Long id = values.getAsLong(GroupMembership.GROUP_ROW_ID);
+                    if (id != null && id == groupId) {
+                        return true;
+                    }
                 }
             }
         }