commit 00848d5b0cd3199fb91171936eb59db7c5e4b6af
author David Brown <dab@google.com> Wed Jun 01 15:00:17 2011 -0700
committer David Brown <dab@google.com> Wed Jun 01 15:00:17 2011 -0700
tree 2b47233cde251188372ebdb91d06619fa4f786b5
parent 9ac11cef9b48a5e23db9eaf0fbeb64fd8ace4e87

Remove tab text in Dialtacts

Remove the text labels from the 4 tabs in the Dialtacts activity, leaving
only the icons.  This allows all 4 tabs to be visible on phone-size
screens in portrait.

This is a short-term fix for ICS dogfooding.  We *will* ultimately bring
back labels at some point, but the exact visual design is still TBD.

Bug: 4520620
Change-Id: I5ecb9a2034bdd4cbc54d298d1318ab6f2d7ed15b

src/com/android/contacts/activities/DialtactsActivity.java

diff --git a/src/com/android/contacts/activities/DialtactsActivity.java b/src/com/android/contacts/activities/DialtactsActivity.java
index 9270565..0b63e46 100644
--- a/src/com/android/contacts/activities/DialtactsActivity.java
+++ b/src/com/android/contacts/activities/DialtactsActivity.java
@@ -174,7 +174,11 @@
 
     private void setupDialer() {
         final Tab tab = getActionBar().newTab();
-        tab.setText(R.string.dialerIconLabel);
+        // TODO: Temporarily disable tab text labels (in all 4 tabs in this
+        //   activity) so that the current tabs will all fit onscreen in
+        //   portrait (bug 4520620).  (Also note we do setText("") rather
+        //   leaving the text null, to work around bug 4521549.)
+        tab.setText("");  // R.string.dialerIconLabel
         tab.setTabListener(new TabChangeListener(mDialpadFragment));
         tab.setIcon(R.drawable.ic_tab_dialer);
         getActionBar().addTab(tab);
@@ -183,7 +187,7 @@
 
     private void setupCallLog() {
         final Tab tab = getActionBar().newTab();
-        tab.setText(R.string.recentCallsIconLabel);
+        tab.setText("");  // R.string.recentCallsIconLabel
         tab.setIcon(R.drawable.ic_tab_recent);
         tab.setTabListener(new TabChangeListener(mCallLogFragment));
         getActionBar().addTab(tab);
@@ -191,7 +195,7 @@
 
     private void setupContacts() {
         final Tab tab = getActionBar().newTab();
-        tab.setText(R.string.contactsIconLabel);
+        tab.setText("");  // R.string.contactsIconLabel
         tab.setIcon(R.drawable.ic_tab_contacts);
         tab.setTabListener(new TabChangeListener(mContactsFragment));
         getActionBar().addTab(tab);
@@ -217,7 +221,7 @@
 
     private void setupFavorites() {
         final Tab tab = getActionBar().newTab();
-        tab.setText(R.string.contactsFavoritesLabel);
+        tab.setText("");  // R.string.contactsFavoritesLabel
         tab.setIcon(R.drawable.ic_tab_starred);
         tab.setTabListener(new TabChangeListener(mStrequentFragment));
         getActionBar().addTab(tab);