commit 4028ac9ae6f56dbd9ee0baab5b76a40ffcb740a5
author George Burgess IV <gbiv@google.com> Mon Feb 12 13:14:52 2018 -0800
committer George Burgess <gbiv@google.com> Tue Feb 13 00:33:26 2018 +0000
tree 42ea6c045fb85eea7a417e7d3c94d6ae8b4718c2
parent 001e6f4650449d576657cb4d1085cbfd743ea9b7

Fix a memory leak

If status < 0, we'd silently leak dev.

Bug: None
Test: Ran the analyzer; memory leak warnings are gone.
Change-Id: I76a78feea4c92aa167de908f5571481864d61d73

modules/gralloc/framebuffer.cpp

diff --git a/modules/gralloc/framebuffer.cpp b/modules/gralloc/framebuffer.cpp
index 9796457..c171711 100644
--- a/modules/gralloc/framebuffer.cpp
+++ b/modules/gralloc/framebuffer.cpp
@@ -332,6 +332,8 @@
             const_cast<int&>(dev->device.minSwapInterval) = 1;
             const_cast<int&>(dev->device.maxSwapInterval) = 1;
             *device = &dev->device.common;
+        } else {
+            free(dev);
         }
     }
     return status;