commit 235942389f797228865c761589732e4b10f42692
author Chih-Hung Hsieh <chh@google.com> Fri Sep 29 15:41:15 2017 -0700
committer Chih-Hung Hsieh <chh@google.com> Wed Oct 04 11:09:30 2017 -0700
tree 0ba8bc4c9eaf41bc43f9d102ec487f53a35a4599
parent ce1ed062440baa9037775c63f333c319fd7d67f4

Use -Werror in hardware/libhardware

* Remove unused local variables and function.
* Fix unused return value warning.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I269eca76cda2222c7a0176e85e92df0bb0924a0e

modules/vibrator/Android.bp

diff --git a/modules/vibrator/Android.bp b/modules/vibrator/Android.bp
index fdbfd61..13ffc83 100644
--- a/modules/vibrator/Android.bp
+++ b/modules/vibrator/Android.bp
@@ -21,5 +21,6 @@
     proprietary: true,
     header_libs: ["libhardware_headers"],
     srcs: ["vibrator.c"],
+    cflags: ["-Wall", "-Werror"],
     shared_libs: ["liblog"],
 }

modules/vibrator/vibrator.c

diff --git a/modules/vibrator/vibrator.c b/modules/vibrator/vibrator.c
index 950bc59..8042b57 100644
--- a/modules/vibrator/vibrator.c
+++ b/modules/vibrator/vibrator.c
@@ -108,7 +108,6 @@
 
 static bool vibra_led_exists()
 {
-    int fd;
     char file_str[50];
 
     snprintf(file_str, sizeof(file_str), "%s/%s", LED_DEVICE, "activate");