commit 1f601b1d7d5f94c6f8f7850e14d1b88e7fb9a775
author Chih-Hung Hsieh <chh@google.com> Tue Nov 14 16:05:46 2017 -0800
committer Chih-Hung Hsieh <chh@google.com> Fri Dec 01 10:37:19 2017 -0800
tree c5b727ec0b0476d83bc8c35bfc44372803163b47
parent 49cf86194541314ec6e42a0ef607d04cd39c36c4

Use -Werror in hardware/libhardware/modules

* Remove unused local variables.
* Remove or comment out unused static functions.
* Fix trivial bugs found by unused value warnings.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I99389b883c89551850180d25241a35a40bb77b26

modules/vehicle/Android.mk

diff --git a/modules/vehicle/Android.mk b/modules/vehicle/Android.mk
index 34c943c..ad2e527 100644
--- a/modules/vehicle/Android.mk
+++ b/modules/vehicle/Android.mk
@@ -21,6 +21,7 @@
 LOCAL_MODULE_RELATIVE_PATH := hw
 LOCAL_PROPRIETARY_MODULE := true
 LOCAL_SRC_FILES := vehicle.c timeUtil.cpp
+LOCAL_CFLAGS := -Wall -Werror
 LOCAL_HEADER_LIBRARIES := libhardware_headers
 LOCAL_SHARED_LIBRARIES := liblog libcutils libutils
 LOCAL_MODULE_TAGS := optional

modules/vehicle/vehicle.c

diff --git a/modules/vehicle/vehicle.c b/modules/vehicle/vehicle.c
index 66e29c0..66a2137 100644
--- a/modules/vehicle/vehicle.c
+++ b/modules/vehicle/vehicle.c
@@ -465,6 +465,9 @@
     }
     int ret_code = pthread_create(
                                   &sub->thread, NULL, (void *(*)(void*))fake_event_thread, sub);
+    if (ret_code != 0) {
+        return -ret_code;
+    }
     print_subscribe_info(impl);
     pthread_mutex_unlock(&lock_);
     return 0;