Use -Werror in hardware/libhardware/modules

* Remove unused local variables.
* Remove or comment out unused static functions.
* Fix trivial bugs found by unused value warnings.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I99389b883c89551850180d25241a35a40bb77b26
diff --git a/modules/camera/3_0/Android.mk b/modules/camera/3_0/Android.mk
index ae68ed5..3071a03 100644
--- a/modules/camera/3_0/Android.mk
+++ b/modules/camera/3_0/Android.mk
@@ -38,7 +38,7 @@
 	libsync \
 	libutils \
 
-LOCAL_CFLAGS += -Wall -Wextra -fvisibility=hidden
+LOCAL_CFLAGS += -Wall -Wextra -Werror -fvisibility=hidden
 
 LOCAL_MODULE_TAGS := optional
 
diff --git a/modules/camera/3_4/Android.mk b/modules/camera/3_4/Android.mk
index d4201ba..ddf843f 100644
--- a/modules/camera/3_4/Android.mk
+++ b/modules/camera/3_4/Android.mk
@@ -32,7 +32,7 @@
 
 v4l2_static_libs :=
 
-v4l2_cflags := -fno-short-enums -Wall -Wextra -fvisibility=hidden
+v4l2_cflags := -fno-short-enums -Wall -Wextra -Werror -fvisibility=hidden
 
 v4l2_c_includes := $(call include-path-for, camera)