commit ff2c6b0d85facde86d4ffdeed903d7f96d9b2d11
author Hongguang Chen <hgchen@google.com> Sat Aug 07 00:12:26 2021 +0000
committer Hongguang <hgchen@google.com> Mon Aug 09 15:41:50 2021 -0700
tree 98448f4186b791593f60d3681215bf68856a3a95
parent 725ae11a95dab419273a4e066bfce88d22ec951b

Add init() to avoid crash when creating ref in constructor.

This reverts commit 50899fb2696d2bb98a4807a237e124f566293f57.

Bug: 195717690
Fix: 195717690
Test: atest VtsHalTvTunerTargetTest
Change-Id: Icae435f1166e6cf2e2f235979e3d1d37d182d517

tv/tuner/aidl/default/Frontend.h

diff --git a/tv/tuner/aidl/default/Frontend.h b/tv/tuner/aidl/default/Frontend.h
index a98cc92..3c602cf 100644
--- a/tv/tuner/aidl/default/Frontend.h
+++ b/tv/tuner/aidl/default/Frontend.h
@@ -33,7 +33,7 @@
 
 class Frontend : public BnFrontend {
   public:
-    Frontend(FrontendType type, int32_t id, Tuner* tuner);
+    Frontend(FrontendType type, int32_t id, std::shared_ptr<Tuner> tuner);
 
     ::ndk::ScopedAStatus setCallback(
             const std::shared_ptr<IFrontendCallback>& in_callback) override;
@@ -59,7 +59,7 @@
     virtual ~Frontend();
     bool supportsSatellite();
     std::shared_ptr<IFrontendCallback> mCallback;
-    Tuner* mTuner;
+    std::shared_ptr<Tuner> mTuner;
     FrontendType mType = FrontendType::UNDEFINED;
     int32_t mId = 0;
     bool mIsLocked = false;