commit b1fb1150bedb434f7788a07d3c54abd12c7acd72
author Shunkai Yao <yaoshunkai@google.com> Thu Feb 20 22:59:30 2025 +0000
committer Shunkai Yao <yaoshunkai@google.com> Fri Feb 21 19:50:45 2025 +0000
tree 7ee2f29547a0e0609a3a7d3d9022b42f30f794aa
parent 3121789c37f078f4a302697bec6b7fedecb53860

VtsHalHapticGeneratorTargetTest: skip data path testing for older HAL

Only run HapticGeneratorDataTest for effect HAL version 3 and above

Flag: EXEMPT Bugfix
Bug: 397561345
Test: atest VtsHalHapticGeneratorTargetTest
Change-Id: I9a56346d15c03ea45c9567bb7ff17732109bfe05

audio/aidl/vts/VtsHalHapticGeneratorTargetTest.cpp

diff --git a/audio/aidl/vts/VtsHalHapticGeneratorTargetTest.cpp b/audio/aidl/vts/VtsHalHapticGeneratorTargetTest.cpp
index 2802bf9..1b0b681 100644
--- a/audio/aidl/vts/VtsHalHapticGeneratorTargetTest.cpp
+++ b/audio/aidl/vts/VtsHalHapticGeneratorTargetTest.cpp
@@ -275,6 +275,9 @@
 enum DataTestParam { EFFECT_INSTANCE, LAYOUT };
 using HapticGeneratorDataTestParam = std::tuple<EffectInstance, int32_t>;
 
+// minimal HAL interface version to run the data path test
+constexpr int32_t kMinDataTestHalVersion = 3;
+
 class HapticGeneratorDataTest : public ::testing::TestWithParam<HapticGeneratorDataTestParam>,
                                 public HapticGeneratorHelper {
   public:
@@ -293,7 +296,14 @@
         mOutput.resize(mHapticSamples + mAudioSamples, 0);
     }
 
-    void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpHapticGenerator(mChMask)); }
+    void SetUp() override {
+        ASSERT_NO_FATAL_FAILURE(SetUpHapticGenerator(mChMask));
+        if (int32_t version;
+            mEffect->getInterfaceVersion(&version).isOk() && version < kMinDataTestHalVersion) {
+            GTEST_SKIP() << "Skipping the data test for version: " << version << "\n";
+        }
+    }
+
     void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownHapticGenerator()); }
 
     void generateSinePeriod() {