commit a90619662b6d0b1874180d9729719061efe4a570
author Tomasz Wasilczyk <twasilczyk@google.com> Mon Nov 04 12:53:09 2019 -0800
committer Tomasz Wasilczyk <twasilczyk@google.com> Wed Nov 06 14:52:07 2019 -0800
tree 705842cf0bfbc47d5dfcdaaebce2268424d85c06
parent 1cebd62c915b33537e766e6b0baa580b24fa8f31

Improve error handling with separate ICanErrorListener

Error handling highlights:
- moved onError from ICanMessageListener to ICanErrorListener
- added isFatal callback argument to request client disconnect
- don't down interface that's already down

Also:
- don't crash if it's not possible to unregister ICanBus
- don't crash while trying to down interface that failed
- make hidl-utils available to vendor libraries

Bug: 143779011
Test: implemented a VHAL service prototype that communicates with this HAL
Change-Id: I98d054da9da0ead5ef952aebc086e052ac996212

automotive/can/1.0/default/CloseHandle.cpp

diff --git a/automotive/can/1.0/default/CloseHandle.cpp b/automotive/can/1.0/default/CloseHandle.cpp
index 13693d2..aba2c49 100644
--- a/automotive/can/1.0/default/CloseHandle.cpp
+++ b/automotive/can/1.0/default/CloseHandle.cpp
@@ -33,7 +33,7 @@
     const auto wasClosed = mIsClosed.exchange(true);
     if (wasClosed) return {};
 
-    mCallback();
+    if (mCallback != nullptr) mCallback();
     return {};
 }