commit a667849ed08197a0811857939d63cdf923f6818d
author Steve Pomeroy <stevepomeroy@google.com> Thu Jul 18 18:50:43 2024 +0000
committer Roshan <rpius@google.com> Wed Jul 24 10:11:33 2024 -0700
tree 6c1cb6370caf9fb71f7b086098331a74d6564dba
parent b38108f4db1400cac050783e835b17de3adeac9e

Use parameterized test to disable test for devices without NFC

Test: atest VtsNfcBehaviorChangesTest
Bug: 345575225
Merged-In: I22393acc260d200d2e472d276c64af005a75ab6b
Change-Id: I22393acc260d200d2e472d276c64af005a75ab6b

nfc/aidl/vts/functional/VtsNfcBehaviorChangesTest.cpp

diff --git a/nfc/aidl/vts/functional/VtsNfcBehaviorChangesTest.cpp b/nfc/aidl/vts/functional/VtsNfcBehaviorChangesTest.cpp
index 0b73cc9..ff2522c 100644
--- a/nfc/aidl/vts/functional/VtsNfcBehaviorChangesTest.cpp
+++ b/nfc/aidl/vts/functional/VtsNfcBehaviorChangesTest.cpp
@@ -16,6 +16,10 @@
 
 #define LOG_TAG "nfc_behavior_changes_test"
 
+#include <aidl/Gtest.h>
+#include <aidl/Vintf.h>
+#include <aidl/android/hardware/nfc/BnNfc.h>
+#include <aidl/android/hardware/nfc/INfc.h>
 #include <android-base/logging.h>
 #include <android-base/stringprintf.h>
 #include <android/binder_process.h>
@@ -30,6 +34,9 @@
 #include "nfa_api.h"
 #include "nfa_ee_api.h"
 
+using aidl::android::hardware::nfc::INfc;
+using android::getAidlHalInstanceNames;
+using android::PrintInstanceNameToString;
 using android::base::StringPrintf;
 
 static SyncEvent sNfaEnableEvent;  // event for NFA_Enable()
@@ -162,7 +169,7 @@
     return status;
 }
 
-class NfcBehaviorChanges : public testing::Test {
+class NfcBehaviorChanges : public testing::TestWithParam<std::string> {
   protected:
     void SetUp() override {
         tNFA_STATUS status = NFA_STATUS_OK;
@@ -202,7 +209,7 @@
  *
  * @VsrTest = GMS-VSR-3.2.8-001
  */
-TEST_F(NfcBehaviorChanges, ObserveModeEnableDisable) {
+TEST_P(NfcBehaviorChanges, ObserveModeEnableDisable) {
     tNFA_STATUS status = nfaObserveModeEnable(true);
     ASSERT_EQ(status, NFA_STATUS_OK);
 
@@ -210,6 +217,11 @@
     ASSERT_EQ(status, NFA_STATUS_OK);
 }
 
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(NfcBehaviorChanges);
+INSTANTIATE_TEST_SUITE_P(Nfc, NfcBehaviorChanges,
+                         testing::ValuesIn(::android::getAidlHalInstanceNames(INfc::descriptor)),
+                         ::android::PrintInstanceNameToString);
+
 int main(int argc, char** argv) {
     testing::InitGoogleTest(&argc, argv);
     ABinderProcess_startThreadPool();