commit 9f9047c7d7d9dd8fdee0bbf2092b91f8e3ae906b
author Jintao Zhu <zhujtcsieee@gmail.com> Sat Mar 13 18:20:17 2021 +0800
committer Steven Moreland <smoreland@google.com> Mon Mar 15 23:32:45 2021 +0000
tree e1ebe329f76c8ae0b2ff320a42d1388e94052e9b
parent 03fb28b9fc2c54aabcea824ebe0608ccbdfabeb0

Fix incorrect Power destruction

(1) As the following call chain indicating, mModule is indeed not pointing to heap memory object, trying to delete it is illegal.
      HIDL_FETCH_IPower -> hw_get_module -> hw_get_module_by_class -> load(hardware/libhardware/hardware.c)

(2) Fix by removing 'delete'

Test: monkey test

Signed-off-by: Jintao Zhu <zhujtcsieee@gmail.com>
Signed-off-by: Steven Moreland <smoreland@google.com>
Change-Id: If95bd8823354cd862d105b96101f910dc1ca95a6

power/1.0/default/Power.cpp

diff --git a/power/1.0/default/Power.cpp b/power/1.0/default/Power.cpp
index 51f87f5..b91a6e8 100644
--- a/power/1.0/default/Power.cpp
+++ b/power/1.0/default/Power.cpp
@@ -35,7 +35,6 @@
 }
 
 Power::~Power() {
-    delete(mModule);
 }
 
 // Methods from ::android::hardware::power::V1_0::IPower follow.