commit 9eb548c0eea59390bdb9b76710c04ac1ae8c458e
author Aayush Soni <aayushsoni@google.com> Tue Oct 22 13:07:47 2024 +0000
committer Aayush Soni <aayush.soni@ittiam.com> Tue Nov 19 15:38:39 2024 +0000
tree 5b0f4f3163b5bafd6b41f730f4bf0b27194d89d9
parent eadfa7a54a215dc06869c87f98c20c3f30352d4e

VisualizerTest: Improve testing for visualizer effect parameters

Add tests for NORMALIZED and AS_PLAYED scaling mode parameters

Bug: 305866207
Test: atest VtsHalVisualizerTargetTest

Change-Id: If6fd9f552a1b1aa6193699d8e14685389c012832

audio/aidl/vts/EffectHelper.h

diff --git a/audio/aidl/vts/EffectHelper.h b/audio/aidl/vts/EffectHelper.h
index d716975..570ecef 100644
--- a/audio/aidl/vts/EffectHelper.h
+++ b/audio/aidl/vts/EffectHelper.h
@@ -375,7 +375,8 @@
                                         std::vector<float>& outputBuffer,
                                         const std::shared_ptr<IEffect>& effect,
                                         IEffect::OpenEffectReturn* openEffectReturn,
-                                        int version = -1, int times = 1) {
+                                        int version = -1, int times = 1,
+                                        bool callStopReset = true) {
         // Initialize AidlMessagequeues
         auto statusMQ = std::make_unique<EffectHelper::StatusMQ>(openEffectReturn->statusMQ);
         ASSERT_TRUE(statusMQ->isValid());
@@ -401,10 +402,14 @@
         }
 
         // Disable the process
-        ASSERT_NO_FATAL_FAILURE(command(effect, CommandId::STOP));
+        if (callStopReset) {
+            ASSERT_NO_FATAL_FAILURE(command(effect, CommandId::STOP));
+        }
         EXPECT_NO_FATAL_FAILURE(EffectHelper::readFromFmq(statusMQ, 0, outputMQ, 0, outputBuffer));
 
-        ASSERT_NO_FATAL_FAILURE(command(effect, CommandId::RESET));
+        if (callStopReset) {
+            ASSERT_NO_FATAL_FAILURE(command(effect, CommandId::RESET));
+        }
     }
 
     // Find FFT bin indices for testFrequencies and get bin center frequencies