commit 8fec556d253f5b3b4bd9b38f3a10f08677425164
author Jeff Pu <jeffpu@google.com> Thu Jul 20 13:07:04 2023 +0000
committer Jeff Pu <jeffpu@google.com> Thu Jul 20 13:51:34 2023 +0000
tree b5fb02ac120d1ba76f07be429c15209ae1d54bc8
parent 13b2b4456500edc5e6aa1a7adf56f344ac544aa3

Authentication state stays on enrollment mismatch

Bug: 291778822
Test: atest FakeFingerprintEngineTest
Change-Id: I4566303af982855aa0ebc52652464fb116a23858

biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp

diff --git a/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp b/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
index 9757287..9f9ca96 100644
--- a/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
+++ b/biometrics/fingerprint/aidl/default/FakeFingerprintEngine.cpp
@@ -258,7 +258,7 @@
         cb->onAuthenticationFailed();
         mLockoutTracker.addFailedAttempt();
         checkSensorLockout(cb);
-        return true;
+        return false;
     }
 }
 

biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp

diff --git a/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp b/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
index e7e8a47..bc235a6 100644
--- a/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
+++ b/biometrics/fingerprint/aidl/default/tests/FakeFingerprintEngineTest.cpp
@@ -269,6 +269,7 @@
     mEngine.authenticateImpl(mCallback.get(), 0, mCancel.get_future());
     mEngine.fingerDownAction();
     ASSERT_TRUE(mCallback->mAuthenticateFailed);
+    ASSERT_EQ(mEngine.getWorkMode(), FakeFingerprintEngine::WorkMode::kAuthenticate);
 }
 
 TEST_F(FakeFingerprintEngineTest, AuthenticateLockout) {