commit 793fab0b07fdec2acc5117367aa3e0a8f66f5dca
author Tomasz Wasilczyk <twasilczyk@google.com> Tue Feb 18 15:19:35 2020 -0800
committer Tomasz Wasilczyk <twasilczyk@google.com> Thu Feb 20 17:10:23 2020 +0000
tree 73d00d02060cb183fc8001cba5bcc9bbad9d9735
parent f3da9b6c1b5ca2f4dfe1e49d3d122e065a9bceba

Add ICanController BAD_SERVICE_NAME error

Bug: 137798319
Test: VTS
Change-Id: I4722346239728f3ab359688658c23441e83671a8

automotive/can/1.0/default/CanController.cpp

diff --git a/automotive/can/1.0/default/CanController.cpp b/automotive/can/1.0/default/CanController.cpp
index dd80402..0700c77 100644
--- a/automotive/can/1.0/default/CanController.cpp
+++ b/automotive/can/1.0/default/CanController.cpp
@@ -48,7 +48,7 @@
 
     if (!isValidName(config.name)) {
         LOG(ERROR) << "Bus name " << config.name << " is invalid";
-        return ICanController::Result::UNKNOWN_ERROR;
+        return ICanController::Result::BAD_SERVICE_NAME;
     }
 
     if (mCanBuses.find(config.name) != mCanBuses.end()) {
@@ -90,7 +90,7 @@
         if (!busService->down()) {
             LOG(WARNING) << "Failed to bring down CAN bus that failed to register";
         }
-        return ICanController::Result::UNKNOWN_ERROR;
+        return ICanController::Result::BAD_SERVICE_NAME;
     }
 
     mCanBuses[config.name] = busService;