codec2: BufferPoolClient: fix NPE in fetchBufferHandle if connection is null
Do a null pointer check before connection->fetch().
Bug: 344846184
Flag: EXEMPT bugfix
Test:
1.atest android.media.decoder.cts.AdaptivePlaybackTest
2.atest android.media.decoder.cts.DecoderTest
Change-Id: I30031b4abf46f920b708320ffa3fa9d1598027b4
diff --git a/media/bufferpool/aidl/default/BufferPoolClient.cpp b/media/bufferpool/aidl/default/BufferPoolClient.cpp
index ce4ad8e..b61893f 100644
--- a/media/bufferpool/aidl/default/BufferPoolClient.cpp
+++ b/media/bufferpool/aidl/default/BufferPoolClient.cpp
@@ -748,6 +748,10 @@
} else {
connection = mRemoteConnection;
}
+ if (!connection) {
+ ALOGE("connection null: fetchBufferHandle()");
+ return ResultStatus::CRITICAL_ERROR;
+ }
std::vector<FetchInfo> infos;
std::vector<FetchResult> results;
infos.emplace_back(FetchInfo{ToAidl(transactionId), ToAidl(bufferId)});