commit 56cbb1125eef8ffdb38481630573b245e4ba4661
author George Chang <georgekgchang@google.com> Tue Jan 25 09:53:28 2022 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jan 25 09:53:28 2022 +0000
tree 40dd7be49b83729775e9cfa92b93edb00f9637e7
parent 2a91bd7331ad07efe9b7d50d9159d2881a9b168e
parent 2e1f26cb4689f2bdddc51e2b10ec6563b481d098

Merge "Add NFC AIDL HAL VTS to presubmit checks"

nfc/aidl/default/Nfc.cpp

diff --git a/nfc/aidl/default/Nfc.cpp b/nfc/aidl/default/Nfc.cpp
index a31ac5e..4685b59 100644
--- a/nfc/aidl/default/Nfc.cpp
+++ b/nfc/aidl/default/Nfc.cpp
@@ -42,24 +42,21 @@
         LOG(INFO) << "Nfc::open null callback";
         return ndk::ScopedAStatus::fromServiceSpecificError(
                 static_cast<int32_t>(NfcStatus::FAILED));
-    } else {
-        Nfc::mCallback = clientCallback;
-
-        clientDeathRecipient = AIBinder_DeathRecipient_new(OnDeath);
-        auto linkRet = AIBinder_linkToDeath(clientCallback->asBinder().get(), clientDeathRecipient,
-                                            this /* cookie */);
-        if (linkRet != STATUS_OK) {
-            LOG(ERROR) << __func__ << ": linkToDeath failed: " << linkRet;
-            // Just ignore the error.
-        }
-
-        int ret = Vendor_hal_open(eventCallback, dataCallback);
-        return ret == 0 ? ndk::ScopedAStatus::ok()
-                        : ndk::ScopedAStatus::fromServiceSpecificError(
-                                  static_cast<int32_t>(NfcStatus::FAILED));
-        return ndk::ScopedAStatus::ok();
     }
-    return ndk::ScopedAStatus::ok();
+    Nfc::mCallback = clientCallback;
+
+    clientDeathRecipient = AIBinder_DeathRecipient_new(OnDeath);
+    auto linkRet = AIBinder_linkToDeath(clientCallback->asBinder().get(), clientDeathRecipient,
+                                        this /* cookie */);
+    if (linkRet != STATUS_OK) {
+        LOG(ERROR) << __func__ << ": linkToDeath failed: " << linkRet;
+        // Just ignore the error.
+    }
+
+    int ret = Vendor_hal_open(eventCallback, dataCallback);
+    return ret == 0 ? ndk::ScopedAStatus::ok()
+                    : ndk::ScopedAStatus::fromServiceSpecificError(
+                              static_cast<int32_t>(NfcStatus::FAILED));
 }
 
 ::ndk::ScopedAStatus Nfc::close(NfcCloseType type) {