commit 521d15c537b410c62cbe0e65c37c6a902f056a81
author Steven Moreland <smoreland@google.com> Tue May 01 16:26:21 2018 -0700
committer Steven Moreland <smoreland@google.com> Mon May 07 09:35:11 2018 -0700
tree b8a4ce041fd66372ce5ab44d301164079b2e38dc
parent af3006428d3d241a40430f634efbb0750525708a

Make dumpstate HAL lazy.

Bug: 78509314
Test: HAL isn't running
Test: adb bugreport HAL runs
Test: HAL isn't running after bugreport finishes
Test: manually inspect state using `lshal` and logs
    using `adb logcat | grep android.hardware.dump`

(cherry picked from commit 711b806727c85d91cf805db4f78b4a9609e2bf43)

Change-Id: Ic97516a4297e7933430fb4fa3fd0109f8c1b1d0a

dumpstate/1.0/default/DumpstateDevice.cpp

diff --git a/dumpstate/1.0/default/DumpstateDevice.cpp b/dumpstate/1.0/default/DumpstateDevice.cpp
index 818a531..88623af 100644
--- a/dumpstate/1.0/default/DumpstateDevice.cpp
+++ b/dumpstate/1.0/default/DumpstateDevice.cpp
@@ -18,6 +18,7 @@
 
 #include "DumpstateDevice.h"
 
+#include <hidl/HidlBinderSupport.h>
 #include <log/log.h>
 
 #include "DumpstateUtil.h"
@@ -37,6 +38,11 @@
     // this interface - since HIDL_FETCH_IDumpstateDevice() is not defined, this function will never
     // be called by dumpstate.
 
+    // Exit when dump is completed since this is a lazy HAL.
+    addPostCommandTask([]() {
+        exit(0);
+    });
+
     if (handle == nullptr || handle->numFds < 1) {
         ALOGE("no FDs\n");
         return Void();

dumpstate/1.0/default/android.hardware.dumpstate@1.0-service.rc

diff --git a/dumpstate/1.0/default/android.hardware.dumpstate@1.0-service.rc b/dumpstate/1.0/default/android.hardware.dumpstate@1.0-service.rc
index adc6cda..dfbfb33 100644
--- a/dumpstate/1.0/default/android.hardware.dumpstate@1.0-service.rc
+++ b/dumpstate/1.0/default/android.hardware.dumpstate@1.0-service.rc
@@ -3,3 +3,5 @@
     user system
     group system
     interface android.hardware.dumpstate@1.0::IDumpstateDevice default
+    oneshot
+    disabled