Address minor comments.
Minor improvement to VHAL logic in responding to code comments at
ag/31125664.
Flag: EXEMPT HAL change
Test: Presubmit
Bug: 382563296
Change-Id: I473360d8e3ace7bb4803a5651f1e67906147b7d0
diff --git a/automotive/vehicle/aidl/impl/current/vhal/include/ConnectedClient.h b/automotive/vehicle/aidl/impl/current/vhal/include/ConnectedClient.h
index 335f5c0..afe1e5e 100644
--- a/automotive/vehicle/aidl/impl/current/vhal/include/ConnectedClient.h
+++ b/automotive/vehicle/aidl/impl/current/vhal/include/ConnectedClient.h
@@ -119,7 +119,7 @@
// Invokes onSupportedValueChange callback.
static void sendSupportedValueChangeEvents(CallbackType callback,
- std::vector<PropIdAreaId> propIdAreaIds);
+ const std::vector<PropIdAreaId>& propIdAreaIds);
};
} // namespace vehicle
diff --git a/automotive/vehicle/aidl/impl/current/vhal/src/ConnectedClient.cpp b/automotive/vehicle/aidl/impl/current/vhal/src/ConnectedClient.cpp
index ac2691a..7271afa 100644
--- a/automotive/vehicle/aidl/impl/current/vhal/src/ConnectedClient.cpp
+++ b/automotive/vehicle/aidl/impl/current/vhal/src/ConnectedClient.cpp
@@ -306,8 +306,9 @@
}
}
-void SubscriptionClient::sendSupportedValueChangeEvents(std::shared_ptr<IVehicleCallback> callback,
- std::vector<PropIdAreaId> propIdAreaIds) {
+void SubscriptionClient::sendSupportedValueChangeEvents(
+ std::shared_ptr<IVehicleCallback> callback,
+ const std::vector<PropIdAreaId>& propIdAreaIds) {
if (propIdAreaIds.empty()) {
return;
}
@@ -323,8 +324,7 @@
if (ScopedAStatus callbackStatus = callback->onSupportedValueChange(vhalPropIdAreaIds);
!callbackStatus.isOk()) {
ALOGE("subscribe: failed to call onSupportedValueChange callback, client ID: %p, error: "
- "%s, "
- "exception: %d, service specific error: %d",
+ "%s, exception: %d, service specific error: %d",
callback->asBinder().get(), callbackStatus.getMessage(),
callbackStatus.getExceptionCode(), callbackStatus.getServiceSpecificError());
}
diff --git a/automotive/vehicle/aidl/impl/current/vhal/src/DefaultVehicleHal.cpp b/automotive/vehicle/aidl/impl/current/vhal/src/DefaultVehicleHal.cpp
index ea0c215..6ed3772 100644
--- a/automotive/vehicle/aidl/impl/current/vhal/src/DefaultVehicleHal.cpp
+++ b/automotive/vehicle/aidl/impl/current/vhal/src/DefaultVehicleHal.cpp
@@ -263,8 +263,7 @@
auto updatedPropIdAreaIdsByClient =
manager->getSubscribedClientsForSupportedValueChange(propIdAreaIds);
for (auto& [callback, updatedPropIdAreaIds] : updatedPropIdAreaIdsByClient) {
- SubscriptionClient::sendSupportedValueChangeEvents(callback,
- std::move(updatedPropIdAreaIds));
+ SubscriptionClient::sendSupportedValueChangeEvents(callback, updatedPropIdAreaIds);
}
}