commit 2c5a8716cdb9b011e60cb7d79d2f099f3058ae27
author Yi Kong <yikong@google.com> Thu Aug 15 14:28:14 2024 +0800
committer Yi Kong <yikong@google.com> Thu Aug 15 14:41:03 2024 +0800
tree 4a0e52d9d6187726798b1b25664947400fb4eb81
parent abda996e895b59e71e5f7344a7501cc29ba78ff3

graphics: Remove unnecessary std::move

Moving a temporary object prevents copy elision, and could reduce
performance.

This fixes -Wpessimizing-move compiler warning.

Test: presubmit
Bug: 154270751
Change-Id: I26d488fb92bf3a9accc20d688da0408e6e19ca93

graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h

diff --git a/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h b/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h
index fbfac87..e9d139d 100644
--- a/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h
+++ b/graphics/composer/aidl/include/android/hardware/graphics/composer3/ComposerClientReader.h
@@ -249,8 +249,7 @@
         auto& data = mReturnData[displayLuts.display];
         for (auto& lut : displayLuts.luts) {
             if (lut.pfd.get() >= 0) {
-                data.luts.push_back({lut.layer,
-                                     std::move(ndk::ScopedFileDescriptor(lut.pfd.release())),
+                data.luts.push_back({lut.layer, ndk::ScopedFileDescriptor(lut.pfd.release()),
                                      lut.lutProperties});
             }
         }