commit 1de01e677c3e4442b29d2e5a1bf01dd04f7b63b5
author Bart Van Assche <bvanassche@google.com> Thu Sep 05 16:08:53 2024 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu Sep 05 16:08:53 2024 +0000
tree 6c551a87e5398bd0599077792232d3bdbc7d71b3
parent 8ab55b06072694de64d90bcdf2f9d951b9412975
parent 4187755208c13f10ac0f7fcdd1f0326d7409a471

Merge changes If286ae5d,I0c89907e into main

* changes:
  libhealthloop: Reduce the size of the uevent receive buffer
  libhealthloop: Modify receive buffer overflow handling

health/utils/libhealthloop/HealthLoop.cpp

diff --git a/health/utils/libhealthloop/HealthLoop.cpp b/health/utils/libhealthloop/HealthLoop.cpp
index 691d896..c5ad5a8 100644
--- a/health/utils/libhealthloop/HealthLoop.cpp
+++ b/health/utils/libhealthloop/HealthLoop.cpp
@@ -64,7 +64,7 @@
                                   .get();
 
     struct epoll_event ev = {
-        .events = EPOLLIN,
+        .events = EPOLLIN | EPOLLERR,
         .data.ptr = reinterpret_cast<void*>(event_handler),
     };
 
@@ -128,6 +128,9 @@
     for (;;) {
         char msg[kUeventMsgLen + 2];
         int n = uevent_kernel_multicast_recv(uevent_fd_, msg, kUeventMsgLen);
+        if (n < 0 && errno == ENOBUFS) {
+            update_stats = true;
+        }
         if (n <= 0) return update_stats;
         if (n >= kUeventMsgLen) {
             // too long -- discard
@@ -177,7 +180,7 @@
 }
 
 void HealthLoop::UeventInit(void) {
-    uevent_fd_.reset(uevent_create_socket(64 * 1024, true));
+    uevent_fd_.reset(uevent_create_socket(kUeventMsgLen, true));
 
     if (uevent_fd_ < 0) {
         KLOG_ERROR(LOG_TAG, "uevent_init: uevent_open_socket failed\n");