commit 1c30a5e3752f3ccbd84cdde57ae14d43ecd2c490
author Yin-Chia Yeh <yinchiayeh@google.com> Wed Nov 28 16:00:16 2018 -0800
committer Yin-Chia Yeh <yinchiayeh@google.com> Tue Jan 08 10:54:10 2019 -0800
tree 5fe2c5b57472a7d1e79b12f35dbb695f6f5f6ac2
parent 8930c48f1e62ff07e7c4c42cb5e620467afb6ef8

Camera: make external camera orientation configurable

Test: webcam preview has correct aspect ratio on phones
Bug: 115774657
Change-Id: I8dcb1a55c4d63c9080f44b85e87d97c138bc5243

camera/device/3.4/default/ExternalCameraDevice.cpp

diff --git a/camera/device/3.4/default/ExternalCameraDevice.cpp b/camera/device/3.4/default/ExternalCameraDevice.cpp
index b96f574..0f23657 100644
--- a/camera/device/3.4/default/ExternalCameraDevice.cpp
+++ b/camera/device/3.4/default/ExternalCameraDevice.cpp
@@ -378,8 +378,12 @@
     const uint8_t timestampSource = ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN;
     UPDATE(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE, &timestampSource, 1);
 
-    // Orientation probably isn't useful for external facing camera?
-    const int32_t orientation = 0;
+    // Orientation is a bit odd for external camera, but consider it as the orientation
+    // between the external camera sensor (which is usually landscape) and the device's
+    // natural display orientation. For devices with natural landscape display (ex: tablet/TV), the
+    // orientation should be 0. For devices with natural portrait display (phone), the orientation
+    // should be 270.
+    const int32_t orientation = mCfg.orientation;
     UPDATE(ANDROID_SENSOR_ORIENTATION, &orientation, 1);
 
     // android.shading