commit fe76013f339325b68f00f3ce4491cf0f1ef3f7e7
author Alex Buynytskyy <alexbuy@google.com> Fri Apr 03 00:38:46 2020 -0700
committer Alex Buynytskyy <alexbuy@google.com> Fri Apr 03 13:55:27 2020 -0700
tree d8800c1dbe5d3579f3510d31a9fa6e282b77532a
parent e8a88834b77ca9d861af1851b3708889bf3be60f

Making native transactions one-way as well.

Fixing crash in native callback after changing permissions.

Bug: b/152633648
Test: adb shell appops set 1000 GET_USAGE_STATS deny
Change-Id: Ifbc2d2d982d2dd9b0b9c0ed109f827de9bed2768

libs/binder/IAppOpsCallback.cpp

diff --git a/libs/binder/IAppOpsCallback.cpp b/libs/binder/IAppOpsCallback.cpp
index 0ce1dd5..b9eb281 100644
--- a/libs/binder/IAppOpsCallback.cpp
+++ b/libs/binder/IAppOpsCallback.cpp
@@ -39,7 +39,7 @@
         data.writeInterfaceToken(IAppOpsCallback::getInterfaceDescriptor());
         data.writeInt32(op);
         data.writeString16(packageName);
-        remote()->transact(OP_CHANGED_TRANSACTION, data, &reply);
+        remote()->transact(OP_CHANGED_TRANSACTION, data, &reply, IBinder::FLAG_ONEWAY);
     }
 };
 
@@ -58,7 +58,6 @@
             String16 packageName;
             (void)data.readString16(&packageName);
             opChanged(op, packageName);
-            reply->writeNoException();
             return NO_ERROR;
         } break;
         default: