commit fdd9f691af51437b63e99c95121dda9030c36c3f
author Yifan Hong <elsk@google.com> Thu Sep 09 15:12:52 2021 -0700
committer Yifan Hong <elsk@google.com> Fri Sep 10 16:40:40 2021 -0700
tree bcc351651a8c00afc2bfb7ee29c7a8b0b6514748
parent 13c9006286d01d7b6de4aca0853d994d695f808b

binder: Delete addTrustedPeerCertificate.

For RpcServer and RpcSession, caller should retain
an ownership of the verifier when creating
RpcTransportCtxFactory, so APIs to addTrustedPeerCertificate
are deleted.

The logic to add certificates should be in the implementation
of RpcCertificateVerifier. See follow-up CLs.

Test: binderRpcTest
Bug: 198833574

Change-Id: If0ed87adfeee2ee48582604881ee335b5d689589

libs/binder/tests/binderRpcTest.cpp

diff --git a/libs/binder/tests/binderRpcTest.cpp b/libs/binder/tests/binderRpcTest.cpp
index 8a03de2..dbf8899 100644
--- a/libs/binder/tests/binderRpcTest.cpp
+++ b/libs/binder/tests/binderRpcTest.cpp
@@ -529,8 +529,7 @@
         status_t status;
 
         for (size_t i = 0; i < options.numSessions; i++) {
-            sp<RpcSession> session =
-                    RpcSession::make(newFactory(rpcSecurity), std::nullopt, std::nullopt);
+            sp<RpcSession> session = RpcSession::make(newFactory(rpcSecurity));
             session->setMaxThreads(options.numIncomingConnections);
 
             switch (socketType) {
@@ -1215,8 +1214,7 @@
     }
     server->start();
 
-    sp<RpcSession> session =
-            RpcSession::make(RpcTransportCtxFactoryRaw::make(), std::nullopt, std::nullopt);
+    sp<RpcSession> session = RpcSession::make(RpcTransportCtxFactoryRaw::make());
     status_t status = session->setupVsockClient(VMADDR_CID_LOCAL, vsockPort);
     while (!server->shutdown()) usleep(10000);
     ALOGE("Detected vsock loopback supported: %s", statusToString(status).c_str());