commit f90df6307eda3bcc53e684bca97b3ec91ea87e00
author liulijun <liulijun@xiaomi.corp-partner.google.com> Mon Nov 14 14:24:48 2022 +0800
committer Ady Abraham <adyabr@google.com> Thu Jan 05 17:24:46 2023 -0800
tree 9036853752193ef4ed4d4fe04cbf5c26a8516a92
parent 2adb9ddf33a03216cd570ea2790ffce17b4ca0ad

Fix an arithmetic error when using unsigned

bug:259000034

Test: by partner
Signed-off-by: Liu Lijun<liulijun@xiaomi.corp-partner.google.com>
Change-Id: I7784f841c04123c99f28705ea6153208be3e383b

libs/gui/BLASTBufferQueue.cpp

diff --git a/libs/gui/BLASTBufferQueue.cpp b/libs/gui/BLASTBufferQueue.cpp
index a51bbb1..1242ac8 100644
--- a/libs/gui/BLASTBufferQueue.cpp
+++ b/libs/gui/BLASTBufferQueue.cpp
@@ -426,8 +426,8 @@
         mCurrentMaxAcquiredBufferCount = *currentMaxAcquiredBufferCount;
     }
 
-    const auto numPendingBuffersToHold =
-            isEGL ? std::max(0u, mMaxAcquiredBuffers - mCurrentMaxAcquiredBufferCount) : 0;
+    const uint32_t numPendingBuffersToHold =
+            isEGL ? std::max(0, mMaxAcquiredBuffers - (int32_t)mCurrentMaxAcquiredBufferCount) : 0;
 
     auto rb = ReleasedBuffer{id, releaseFence};
     if (std::find(mPendingRelease.begin(), mPendingRelease.end(), rb) == mPendingRelease.end()) {