commit f8734e014d3a5596be2edc6ee85dbda7589bb889
author Dominik Laskowski <domlaskowski@google.com> Fri Aug 26 09:06:59 2022 -0700
committer Dominik Laskowski <domlaskowski@google.com> Thu Sep 08 08:48:21 2022 -0700
tree fd30cadac81cfd364477ef0c9247fc8ea7b32dbf
parent f2595446af5d9bf2ca4b2e5bf07dfbbd842e61ec

SF: Enforce thread safety of active mode access

Provide two RefreshRateConfigs APIs for retrieving the active mode:
getActiveMode for access from the main thread (which does not need
to lock nor copy), and getActiveModePtr for other threads.

Bug: 241285191
Test: Build (-Wthread-safety)
Change-Id: If156d85861ec2d82a394ba181314a6ba3048974f

services/surfaceflinger/Layer.cpp

diff --git a/services/surfaceflinger/Layer.cpp b/services/surfaceflinger/Layer.cpp
index 47bd91e..701071b 100644
--- a/services/surfaceflinger/Layer.cpp
+++ b/services/surfaceflinger/Layer.cpp
@@ -3947,7 +3947,7 @@
     }
 
     if (display) {
-        const Fps refreshRate = display->refreshRateConfigs().getActiveMode()->getFps();
+        const Fps refreshRate = display->refreshRateConfigs().getActiveModePtr()->getFps();
         const std::optional<Fps> renderRate =
                 mFlinger->mScheduler->getFrameRateOverride(getOwnerUid());