SurfaceFlinger: fix calculation issues with refresh rate selection
- Initialize BufferQueueCore::mFrameRate
- Load BufferQueueLayer::mLatchedFrameRate value before using it
- Fix a bug with LayerInfoV2 where a frequent layer needs to post at least
FREQUENT_LAYER_WINDOW_SIZE buffers.
- Fix casting issues in RefreshRateConfigs
Test: adb shell /data/nativetest64/libsurfaceflinger_unittest/libsurfaceflinger_unittest
Bug: 147516364
Change-Id: Ie6e93ef2f4dd3a030bfd0dbbf8018d96680d8bb3
diff --git a/services/surfaceflinger/Scheduler/LayerInfoV2.cpp b/services/surfaceflinger/Scheduler/LayerInfoV2.cpp
index d94d758..f309d4d 100644
--- a/services/surfaceflinger/Scheduler/LayerInfoV2.cpp
+++ b/services/surfaceflinger/Scheduler/LayerInfoV2.cpp
@@ -57,7 +57,7 @@
bool LayerInfoV2::isFrequent(nsecs_t now) const {
// Assume layer is infrequent if too few present times have been recorded.
if (mFrameTimes.size() < FREQUENT_LAYER_WINDOW_SIZE) {
- return true;
+ return false;
}
// Layer is frequent if the earliest value in the window of most recent present times is
@@ -100,8 +100,7 @@
static_cast<float>(totalPresentTimeDeltas) / (mFrameTimes.size() - 1);
// Now once we calculated the refresh rate we need to make sure that all the frames we captured
- // are evenly distrubuted and we don't calculate the average across some burst of frames.
-
+ // are evenly distributed and we don't calculate the average across some burst of frames.
for (auto it = mFrameTimes.begin(); it != mFrameTimes.end() - 1; ++it) {
const nsecs_t presentTimeDeltas =
std::max(((it + 1)->presetTime - it->presetTime), mHighRefreshRatePeriod);