commit f59c2b7ad16b19ba00765d75d38fec74fe8f9435
author Paul Chang <changpa@google.com> Tue Mar 10 02:08:55 2020 +0800
committer Paul Chang <changpa@google.com> Wed Mar 11 10:38:17 2020 +0000
tree a33eba2d753c14ea28a473b1c1bb53cf2ca49d2a
parent 7190e99bf166c2cc71ed1c9de592f33eed6ad713

Take screenshot only when screenshot is requested

- Take screenshot only when screenshot is requested for preventing from taking screenshot unnecessarily

BUG: 149525300
Test: Flash and test interactive/full bugreports generated using Shell, and Shell flow does not break during tests
Change-Id: Ie5cbe97f9e6e32fecc3d95893b9804b6e716c628

cmds/dumpstate/DumpstateService.h

diff --git a/cmds/dumpstate/DumpstateService.h b/cmds/dumpstate/DumpstateService.h
index 6dc0225..ac8d3ac 100644
--- a/cmds/dumpstate/DumpstateService.h
+++ b/cmds/dumpstate/DumpstateService.h
@@ -41,7 +41,8 @@
     binder::Status startBugreport(int32_t calling_uid, const std::string& calling_package,
                                   android::base::unique_fd bugreport_fd,
                                   android::base::unique_fd screenshot_fd, int bugreport_mode,
-                                  const sp<IDumpstateListener>& listener) override;
+                                  const sp<IDumpstateListener>& listener,
+                                  bool is_screenshot_requested) override;
 
     // No-op
     binder::Status cancelBugreport();