commit f2588a8172a8481e4989924098eafa08a145b5c1
author Cody Northrop <cnorthrop@google.com> Mon Mar 27 23:03:49 2023 -0600
committer Cody Northrop <cnorthrop@google.com> Mon Apr 03 15:05:48 2023 -0600
tree 3eca8330e2d880e2fb1bf1d5959f56739350870a
parent be16373f15a245b4c14ad4f84b20ff8e76741893

EGL BlobCache: Trim immediately on multifile overflow

While adding a fuzzer for this feature, discovered that
cache trimming wasn't happening right when the overflow
happened, but on the next iteration.

This CL updates the code to make it trim right away, since
we've already determined it needs to happen.

Also add a test to ensure trimming happens right away.

Test: /data/nativetest64/EGL_test/EGL_test
Bug: b/266725576
Change-Id: Ica1e9ca688268e7e746750c27acdfced04e74b06

opengl/libs/EGL/MultifileBlobCache.h

diff --git a/opengl/libs/EGL/MultifileBlobCache.h b/opengl/libs/EGL/MultifileBlobCache.h
index b461ef4..f266011 100644
--- a/opengl/libs/EGL/MultifileBlobCache.h
+++ b/opengl/libs/EGL/MultifileBlobCache.h
@@ -119,7 +119,7 @@
     bool addToHotCache(uint32_t entryHash, int fd, uint8_t* entryBufer, size_t entrySize);
     bool removeFromHotCache(uint32_t entryHash);
 
-    void trimCache(size_t cacheByteLimit);
+    void trimCache();
     bool applyLRU(size_t cacheLimit);
 
     bool mInitialized;