commit f2156e1a32f75221a87121d9c0d5be27adaaf009
author Alec Mouri <alecmouri@google.com> Thu May 14 13:00:52 2020 -0700
committer Alec Mouri <alecmouri@google.com> Thu May 14 21:08:48 2020 +0000
tree c3201a9b8ec31d642a79863ebe67f360583e1c63
parent 9adccca5dd6186173b5049996e55e1d637dc44a6

Remove hot-path logging

Turns out debug logging isn't cheap. Keeping the trace so that we can
still track it.

Bug: 144289346
Test: builds
Change-Id: I5d04f0d7821f89f1fe471ee67b165deef249ab50

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 4cd1c9b..ddda21d 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -1917,13 +1917,9 @@
             const nsecs_t jankDuration = currentTime - mMissedFrameJankStart;
             if (jankDuration > kMinJankyDuration && jankDuration < kMaxJankyDuration) {
                 ATRACE_NAME("Jank detected");
-                ALOGD("Detected janky event. Missed frames: %d", mMissedFrameJankCount);
                 const int32_t jankyDurationMillis = jankDuration / (1000 * 1000);
-                {
-                    ATRACE_NAME("Pushing to statsd");
-                    android::util::stats_write(android::util::DISPLAY_JANK_REPORTED,
-                                               jankyDurationMillis, mMissedFrameJankCount);
-                }
+                android::util::stats_write(android::util::DISPLAY_JANK_REPORTED,
+                                           jankyDurationMillis, mMissedFrameJankCount);
             }
 
             // We either reported a jank event or we missed the trace