commit ebf4917cc44a1423e79529795f9c394dd44045be
author Arpit Singh <arpitks@google.com> Wed Jan 22 12:51:52 2025 +0000
committer Arpit Singh <arpitks@google.com> Wed Jan 22 13:01:26 2025 +0000
tree 3b8f17931db98d8b2ddd3c917b52f0658152768d
parent a29a2d1431f5b3b2c18cd10e7fedfe01f75d5999

Use EXPECT_NEAR for float values in expectTap

There are some tests failures due to mismatch in float precision
values.

Bug: 388925244
Test: atest libgui_test
Flag: TEST_ONLY
Change-Id: I38a5039f2c9c288cd4e573573b985c6e3cf6b7ec

libs/gui/tests/EndToEndNativeInputTest.cpp

diff --git a/libs/gui/tests/EndToEndNativeInputTest.cpp b/libs/gui/tests/EndToEndNativeInputTest.cpp
index 06f00a4..8062a2e 100644
--- a/libs/gui/tests/EndToEndNativeInputTest.cpp
+++ b/libs/gui/tests/EndToEndNativeInputTest.cpp
@@ -85,6 +85,7 @@
 // We use the top 10 layers as a way to haphazardly place ourselves above anything else.
 static const int LAYER_BASE = INT32_MAX - 10;
 static constexpr std::chrono::nanoseconds DISPATCHING_TIMEOUT = 5s;
+static constexpr float EPSILON = MotionEvent::ROUNDING_PRECISION;
 
 class SynchronousWindowInfosReportedListener : public gui::BnWindowInfosReportedListener {
 public:
@@ -203,8 +204,8 @@
         ASSERT_EQ(InputEventType::MOTION, ev->getType());
         MotionEvent* mev = static_cast<MotionEvent*>(ev);
         EXPECT_EQ(AMOTION_EVENT_ACTION_DOWN, mev->getAction());
-        EXPECT_EQ(x, mev->getX(0));
-        EXPECT_EQ(y, mev->getY(0));
+        EXPECT_NEAR(x, mev->getX(0), EPSILON);
+        EXPECT_NEAR(y, mev->getY(0), EPSILON);
         EXPECT_EQ(0, mev->getFlags() & VERIFIED_MOTION_EVENT_FLAGS);
 
         ev = consumeEvent();