Fix for-loop type.
Technically the iterator provides a std::pair<const KEY, VALUE>&, so
we're constructing a std::pair<KEY, VALUE> from it and then taking a
const reference to that. This creates an unnecessary copy but then
obscures that by taking a reference to it; we should either take a
reference to the iterator's actual type or use the value type of the
temporary we construct directly.
Bug: N/A
Test: compile
Change-Id: I0ed11c1a80a5ac419f74f100573d4a2f042141fd
diff --git a/services/inputflinger/reader/mapper/JoystickInputMapper.cpp b/services/inputflinger/reader/mapper/JoystickInputMapper.cpp
index ac4669c..28f29e0 100644
--- a/services/inputflinger/reader/mapper/JoystickInputMapper.cpp
+++ b/services/inputflinger/reader/mapper/JoystickInputMapper.cpp
@@ -206,7 +206,7 @@
}
bool JoystickInputMapper::haveAxis(int32_t axisId) {
- for (const std::pair<int32_t, Axis>& pair : mAxes) {
+ for (const std::pair<const int32_t, Axis>& pair : mAxes) {
const Axis& axis = pair.second;
if (axis.axisInfo.axis == axisId ||
(axis.axisInfo.mode == AxisInfo::MODE_SPLIT && axis.axisInfo.highAxis == axisId)) {