commit d98952d07f290edf7672d5fcfa9bdbac4e513a0d
author Steven Moreland <smoreland@google.com> Thu May 11 23:27:43 2023 +0000
committer Steven Moreland <smoreland@google.com> Thu May 11 23:28:38 2023 +0000
tree 01701c10bab352f90b5805205f3613b18c97ed72
parent 71ea90d35134e972978f92add142857a10104552

servicemanager: log if doesn't become ctx mgr

Currently, this is a silent failure.

This is made to be fatal in a separate patch, for
revertability.

Bug: 280514080
Test: boot
Change-Id: If5a524f056d77905c818f466c5c677666caa1640

cmds/servicemanager/main.cpp

diff --git a/cmds/servicemanager/main.cpp b/cmds/servicemanager/main.cpp
index c1a04dd..520d6f9 100644
--- a/cmds/servicemanager/main.cpp
+++ b/cmds/servicemanager/main.cpp
@@ -131,7 +131,10 @@
     }
 
     IPCThreadState::self()->setTheContextObject(manager);
-    ps->becomeContextManager();
+    if (!ps->becomeContextManager()) {
+        LOG(ERROR) << "Could not become context manager";
+        // TODO(b/280514080): fatal
+    }
 
     sp<Looper> looper = Looper::prepare(false /*allowNonCallbacks*/);