commit d8c000deb8a603c90ff9c44efc1337ba500a6dfd
author Tianyu Jiang <tianyuj@google.com> Fri Sep 14 23:40:23 2018 +0000
committer Tianyu Jiang <tianyuj@google.com> Fri Sep 14 23:40:23 2018 +0000
tree 8826e1368015c7270c91a98325dd0683484755c5
parent 3be4ebb025c6a21547aec7bb79c144a8b000bc46

Revert "Fix return error"

This reverts commit 3be4ebb025c6a21547aec7bb79c144a8b000bc46.

Reason for revert: crash on Vega on oc-dr1-daydream-dev branch

Change-Id: I939c87ca66ad62dbeb8b696c08a2d539180dfe7c

libs/vr/libbufferhubqueue/buffer_hub_queue_client.cpp

diff --git a/libs/vr/libbufferhubqueue/buffer_hub_queue_client.cpp b/libs/vr/libbufferhubqueue/buffer_hub_queue_client.cpp
index a296d20..1f2c517 100644
--- a/libs/vr/libbufferhubqueue/buffer_hub_queue_client.cpp
+++ b/libs/vr/libbufferhubqueue/buffer_hub_queue_client.cpp
@@ -440,9 +440,6 @@
 Status<std::vector<size_t>> ProducerQueue::AllocateBuffers(
     uint32_t width, uint32_t height, uint32_t layer_count, uint32_t format,
     uint64_t usage, size_t buffer_count) {
-  if (buffer_count == 0) {
-    return {};
-  }
   if (capacity() + buffer_count > kMaxQueueCapacity) {
     ALOGE(
         "ProducerQueue::AllocateBuffers: queue is at capacity: %zu, cannot "
@@ -484,13 +481,10 @@
     }
   }
 
-  if (buffer_slots.size() != buffer_count) {
-    // Error out if the count of allocated/imported buffer(s) is not correct.
-    ALOGE(
-        "ProducerQueue::AllocateBuffers: requested to import %zu "
-        "buffers, but actually imported %zu buffers.",
-        buffer_count, buffer_slots.size());
-    return ErrorStatus(ENOMEM);
+  if (buffer_slots.size() == 0) {
+    // Error out if no buffer is allocated and improted.
+    ALOGE_IF(TRACE, "ProducerQueue::AllocateBuffers: no buffer allocated.");
+    ErrorStatus(ENOMEM);
   }
 
   return {std::move(buffer_slots)};
@@ -508,6 +502,12 @@
           status.GetErrorMessage().c_str());
     return status.error_status();
   }
+
+  if (status.get().size() == 0) {
+    ALOGE_IF(TRACE, "ProducerQueue::AllocateBuffer: no buffer allocated.");
+    ErrorStatus(ENOMEM);
+  }
+
   return {status.get()[0]};
 }
 

libs/vr/libbufferhubqueue/tests/buffer_hub_queue-test.cpp

diff --git a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue-test.cpp b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue-test.cpp
index c1f322c..2975f56 100644
--- a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue-test.cpp
+++ b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue-test.cpp
@@ -562,28 +562,6 @@
   ASSERT_EQ(cs2, ps2);
 }
 
-TEST_F(BufferHubQueueTest, TestAllocateTwoBuffers) {
-  ASSERT_TRUE(CreateQueues(config_builder_.Build(), UsagePolicy{}));
-  ASSERT_EQ(producer_queue_->capacity(), 0);
-
-  auto status = producer_queue_->AllocateBuffers(
-      kBufferWidth, kBufferHeight, kBufferLayerCount, kBufferFormat,
-      kBufferUsage, 2);
-  ASSERT_TRUE(status.ok());
-  ASSERT_EQ(producer_queue_->capacity(), 2);
-}
-
-TEST_F(BufferHubQueueTest, TestAllocateZeroBuffers) {
-  ASSERT_TRUE(CreateQueues(config_builder_.Build(), UsagePolicy{}));
-  ASSERT_EQ(producer_queue_->capacity(), 0);
-
-  auto status = producer_queue_->AllocateBuffers(
-      kBufferWidth, kBufferHeight, kBufferLayerCount, kBufferFormat,
-      kBufferUsage, 0);
-  ASSERT_TRUE(status.ok());
-  ASSERT_EQ(producer_queue_->capacity(), 0);
-}
-
 TEST_F(BufferHubQueueTest, TestUsageSetMask) {
   const uint32_t set_mask = GRALLOC_USAGE_SW_WRITE_OFTEN;
   ASSERT_TRUE(