MotionEvent: Avoid clipping tranformed orientation angle values
A recent refactor (ag/14556109) exposed an issue in the existing
orientation angle transformation logic where the output was clipped
incorrectly. There is no need to clip the ouput of atan2f because its
output is in the range [-pi, pi], which conforms to the MotionEvent's
orientation API.
Test: manual with stylus and test app
Bug: 202534592
Change-Id: I55df7470049922d0f579c2c1921dcacd0757ece1
diff --git a/libs/input/Input.cpp b/libs/input/Input.cpp
index 390ff96..b4d9ab6 100644
--- a/libs/input/Input.cpp
+++ b/libs/input/Input.cpp
@@ -56,13 +56,8 @@
transformedPoint.y -= origin.y;
// Derive the transformed vector's clockwise angle from vertical.
- float result = atan2f(transformedPoint.x, -transformedPoint.y);
- if (result < -M_PI_2) {
- result += M_PI;
- } else if (result > M_PI_2) {
- result -= M_PI;
- }
- return result;
+ // The return value of atan2f is in range [-pi, pi] which conforms to the orientation API.
+ return atan2f(transformedPoint.x, -transformedPoint.y);
}
vec2 transformWithoutTranslation(const ui::Transform& transform, const vec2& xy) {