commit d08d9dea7d908c6b1afadb63f7a604f0f12ad209
author Devin Moore <devinmoore@google.com> Mon Sep 09 20:09:21 2024 +0000
committer Devin Moore <devinmoore@google.com> Mon Sep 09 23:23:39 2024 +0000
tree 91eeac0757165a24d1d5b8f035612a43d6c9d68e
parent 9f4086816e2002ce3c96b11288bb12f05e054d15

Add some error logs for FdTrigger errors

Test: m && launch_cvd && check logs to make sure no errors
Bug: none
Change-Id: I5355179c9c3480071b5cc419dd195b7af6509b70

libs/binder/FdTrigger.cpp

diff --git a/libs/binder/FdTrigger.cpp b/libs/binder/FdTrigger.cpp
index 455a433..f0aa801 100644
--- a/libs/binder/FdTrigger.cpp
+++ b/libs/binder/FdTrigger.cpp
@@ -82,7 +82,9 @@
 
     int ret = TEMP_FAILURE_RETRY(poll(pfd, countof(pfd), -1));
     if (ret < 0) {
-        return -errno;
+        int saved_errno = errno;
+        ALOGE("FdTrigger poll returned error: %d, with error: %s", ret, strerror(saved_errno));
+        return -saved_errno;
     }
     LOG_ALWAYS_FATAL_IF(ret == 0, "poll(%d) returns 0 with infinite timeout", transportFd.fd.get());
 
@@ -106,6 +108,7 @@
 
     // POLLNVAL: invalid FD number, e.g. not opened.
     if (pfd[0].revents & POLLNVAL) {
+        ALOGE("Invalid FD number (%d) in FdTrigger (POLLNVAL)", pfd[0].fd);
         return BAD_VALUE;
     }