commit cc09fccf625216eb35b90fdd22c27e4f54b06636
author Chia-I Wu <olv@google.com> Thu May 25 21:27:21 2017 +0000
committer android-build-merger <android-build-merger@google.com> Thu May 25 21:27:21 2017 +0000
tree cd4b9d49185f8d7c584e81248d877888e6f4bb2f
parent 3d69648490add3f818fb4f015db583aa6e217a1f
parent feec3b1a49dbf48bc792d39d004b42cf2c72b14c

libgui: fix BQ buffer allocation error checking
am: feec3b1a49

Change-Id: Ie63b629a8eb0f4c08eadbcf3a40ceaf8346a71ba

libs/gui/BufferQueueProducer.cpp

diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp
index 6a5593c..3d57769 100644
--- a/libs/gui/BufferQueueProducer.cpp
+++ b/libs/gui/BufferQueueProducer.cpp
@@ -511,7 +511,7 @@
         { // Autolock scope
             Mutex::Autolock lock(mCore->mMutex);
 
-            if (graphicBuffer != NULL && !mCore->mIsAbandoned) {
+            if (error == NO_ERROR && !mCore->mIsAbandoned) {
                 graphicBuffer->setGenerationNumber(mCore->mGenerationNumber);
                 mSlots[*outSlot].mGraphicBuffer = graphicBuffer;
             }
@@ -519,7 +519,7 @@
             mCore->mIsAllocating = false;
             mCore->mIsAllocatingCondition.broadcast();
 
-            if (graphicBuffer == NULL) {
+            if (error != NO_ERROR) {
                 mCore->mFreeSlots.insert(*outSlot);
                 mCore->clearBufferSlotLocked(*outSlot);
                 BQ_LOGE("dequeueBuffer: createGraphicBuffer failed");