commit cbf278a57c60ed43cb95259347eaf5137b715f9f
author Ray Chen <rayljchen@google.com> Mon Nov 20 07:49:45 2023 +0000
committer Ray Chen <rayljchen@google.com> Tue Nov 21 03:31:13 2023 +0000
tree de1e708d021bd8344187c2ee4f427e58ca8ea2ef
parent a82e90f52e5fc0472627b58ce73969fdb36026d5

Add network link statistics to bugreport

Instead of using the "ip link" command, this change utilizes the
"ip -s link" command to gather network link statistics, facilitating the
identification of connectivity problems.

Before:
------ NETWORK INTERFACES (ip link) ------
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode
   DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
...

After:
------ NETWORK INTERFACES (ip -s link) ------
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode
   DEFAULT group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    RX: bytes  packets  errors  dropped overrun mcast
    672        8        0       0       0       0
    TX: bytes  packets  errors  dropped carrier collsns
    672        8        0       0       0       0
...

Bug: 145748752
Test: manually check the bugreport generated by device
Change-Id: I299c3d7e2cbd4e99a1b058d751e5563306f7b8b1

cmds/dumpstate/dumpstate.cpp

diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp
index 6fdf1c5..2965a59 100644
--- a/cmds/dumpstate/dumpstate.cpp
+++ b/cmds/dumpstate/dumpstate.cpp
@@ -1236,7 +1236,7 @@
 
 static void DumpIpAddrAndRules() {
     /* The following have a tendency to get wedged when wifi drivers/fw goes belly-up. */
-    RunCommand("NETWORK INTERFACES", {"ip", "link"});
+    RunCommand("NETWORK INTERFACES", {"ip", "-s", "link"});
     RunCommand("IPv4 ADDRESSES", {"ip", "-4", "addr", "show"});
     RunCommand("IPv6 ADDRESSES", {"ip", "-6", "addr", "show"});
     RunCommand("IP RULES", {"ip", "rule", "show"});