commit c94dafee70fcd1db9ada181b7673ba8722e8598e
author Siarhei Vishniakou <svv@google.com> Fri May 26 10:24:19 2023 -0700
committer Siarhei Vishniakou <svv@google.com> Wed Jun 07 01:23:31 2023 +0000
tree 6278946406523b4726c4e11162dc0fd5a6b05225
parent f6e3079e847a8a61bfb5ba4400ce3074bd4fc6c7

Add log for events dropped by InputState

Before this CL, events could be silently dropped. This is because
InputState acts as a "verifier" in a way - if an incorrect stream is
detected, it doesn't crash, but simply skips the event.

In this CL, log is added so that we learn about these drops if something
goes wrong.
In theory, this should never happen because the InputState should never
receive an inconsistent stream to begin with.

Bug: 281806933
Note: the actual test will be added in a later patch
Test: m inputflinger_tests && adb sync data && adb shell -t data/nativetest64/inputflinger_tests/inputflinger_tests --gtest_filter="*MultiplePointersWithRotatingWindow"
Change-Id: I1a0b417872d03e3b1b11dd68b9bbe3a0dc057a14

services/inputflinger/dispatcher/InputState.cpp

diff --git a/services/inputflinger/dispatcher/InputState.cpp b/services/inputflinger/dispatcher/InputState.cpp
index 4652c2d..2fcb89a 100644
--- a/services/inputflinger/dispatcher/InputState.cpp
+++ b/services/inputflinger/dispatcher/InputState.cpp
@@ -93,11 +93,7 @@
                 mMotionMementos.erase(mMotionMementos.begin() + index);
                 return true;
             }
-            if (DEBUG_OUTBOUND_EVENT_DETAILS) {
-                ALOGD("Dropping inconsistent motion up or cancel event: deviceId=%d, source=%08x, "
-                      "displayId=%" PRId32 ", actionMasked=%d",
-                      entry.deviceId, entry.source, entry.displayId, actionMasked);
-            }
+
             return false;
         }
 
@@ -150,11 +146,7 @@
                     return true;
                 }
             }
-            if (DEBUG_OUTBOUND_EVENT_DETAILS) {
-                ALOGD("Dropping inconsistent motion pointer up/down or move event: "
-                      "deviceId=%d, source=%08x, displayId=%" PRId32 ", actionMasked=%d",
-                      entry.deviceId, entry.source, entry.displayId, actionMasked);
-            }
+
             return false;
         }
 
@@ -164,11 +156,7 @@
                 mMotionMementos.erase(mMotionMementos.begin() + index);
                 return true;
             }
-            if (DEBUG_OUTBOUND_EVENT_DETAILS) {
-                ALOGD("Dropping inconsistent motion hover exit event: deviceId=%d, source=%08x, "
-                      "displayId=%" PRId32,
-                      entry.deviceId, entry.source, entry.displayId);
-            }
+
             return false;
         }