commit c7ecca34b9e08a09fb39d7abeac5ee72ae141378
author TreeHugger Robot <treehugger-gerrit@google.com> Mon Jan 14 23:20:10 2019 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Mon Jan 14 23:20:10 2019 +0000
tree bbc456a349c21adacd71e7601ef95c0d13e23c08
parent 77081f8a47ee575880d7a5244a6827a424f3054d
parent 876a049fd49f26dbb1607a285ed740ab8ffc8767

Merge "BufferHubBuffer.cpp: replace dup() with fcntl(F_DUPFD_CLOEXEC)"

libs/ui/BufferHubBuffer.cpp

diff --git a/libs/ui/BufferHubBuffer.cpp b/libs/ui/BufferHubBuffer.cpp
index c70f188..052e650 100644
--- a/libs/ui/BufferHubBuffer.cpp
+++ b/libs/ui/BufferHubBuffer.cpp
@@ -181,7 +181,7 @@
     }
 
     // Import the metadata. Dup since hidl_handle owns the fd
-    unique_fd ashmemFd(dup(bufferTraits.bufferInfo->data[0]));
+    unique_fd ashmemFd(fcntl(bufferTraits.bufferInfo->data[0], F_DUPFD_CLOEXEC, 0));
     mMetadata = BufferHubMetadata::Import(std::move(ashmemFd));
 
     if (!mMetadata.IsValid()) {