commit c520831fb7ea03e9d515add9b2d96d423b3b6093
author Lloyd Pique <lpique@google.com> Mon Jan 08 17:59:02 2018 -0800
committer Lloyd Pique <lpique@google.com> Thu Jan 11 12:45:01 2018 -0800
tree f8f6fd74149ee9731e714e1ff30613be4041f2e8
parent 2ae2b3bd5bfbacc3b52f222441bfbbeb9bd54dc7

Use wide color modes with external displays

A prior code cleanup made it obvious that wide color modes were only
being used for the primary display. This patch allows external displays
to use wide color modes, and adds a requested TODO to update a variable
name.

Bug: None
Test: Builds
Change-Id: Iec262e51674a2a2f7fcfc9177c7bfbf0b1a860e3

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index bfa239d..f21a691 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -136,6 +136,7 @@
 bool SurfaceFlinger::hasSyncFramework;
 bool SurfaceFlinger::useVrFlinger;
 int64_t SurfaceFlinger::maxFrameBufferAcquiredBuffers;
+// TODO(courtneygo): Rename hasWideColorDisplay to clarify its actual meaning.
 bool SurfaceFlinger::hasWideColorDisplay;
 
 
@@ -2238,7 +2239,7 @@
 
                 if (dispSurface != nullptr) {
                     bool useWideColorMode = hasWideColorDisplay;
-                    if (state.isMainDisplay()) {
+                    if (!mForceNativeColorMode) {
                         bool hasWideColorModes = false;
                         std::vector<android_color_mode_t> modes =
                                 getHwComposer().getColorModes(state.type);
@@ -2253,26 +2254,23 @@
                                     break;
                             }
                         }
-                        useWideColorMode = hasWideColorModes && hasWideColorDisplay &&
-                                !mForceNativeColorMode;
+                        useWideColorMode = hasWideColorModes && hasWideColorDisplay;
                     }
 
                     sp<DisplayDevice> hw =
                             new DisplayDevice(this, state.type, hwcId, state.isSecure, display,
                                               dispSurface, producer, useWideColorMode);
 
-                    if (state.isMainDisplay()) {
-                        android_color_mode defaultColorMode = HAL_COLOR_MODE_NATIVE;
-                        if (useWideColorMode) {
-                            defaultColorMode = HAL_COLOR_MODE_SRGB;
-                        }
-                        setActiveColorModeInternal(hw, defaultColorMode);
-                        hw->setCompositionDataSpace(HAL_DATASPACE_UNKNOWN);
+                    android_color_mode defaultColorMode = HAL_COLOR_MODE_NATIVE;
+                    if (useWideColorMode) {
+                        defaultColorMode = HAL_COLOR_MODE_SRGB;
                     }
-
+                    setActiveColorModeInternal(hw, defaultColorMode);
+                    hw->setCompositionDataSpace(HAL_DATASPACE_UNKNOWN);
                     hw->setLayerStack(state.layerStack);
                     hw->setProjection(state.orientation, state.viewport, state.frame);
                     hw->setDisplayName(state.displayName);
+
                     mDisplays.add(display, hw);
                     if (!state.isVirtualDisplay()) {
                         mEventThread->onHotplugReceived(state.type, true);