commit c2867147707ca1bc49b6102675056f0304872ac5
author Dominik Laskowski <domlaskowski@google.com> Mon Jan 21 11:33:38 2019 -0800
committer Dominik Laskowski <domlaskowski@google.com> Wed Jan 23 16:49:12 2019 -0800
tree d6bd02d50f4bc661a222e1e62cce4344cb0c42c6
parent 8cf0bfa7a15e72ac57735774dd5ced09316a1816

SF: Simplify dumpsys flag parsing

This CL removes sequential parsing for dumpsys flags, which was order-
dependent and boilerplate-heavy.

Note that flags cannot be combined for simplicity.

Bug: None
Test: dumpsys SurfaceFlinger [--FLAG [ARGS...]]
Change-Id: Id305ffee464c6cad4f228c7a7f603c33a2978d66

services/surfaceflinger/tests/unittests/TimeStatsTest.cpp

diff --git a/services/surfaceflinger/tests/unittests/TimeStatsTest.cpp b/services/surfaceflinger/tests/unittests/TimeStatsTest.cpp
index 86f1a39..0f95cf9 100644
--- a/services/surfaceflinger/tests/unittests/TimeStatsTest.cpp
+++ b/services/surfaceflinger/tests/unittests/TimeStatsTest.cpp
@@ -131,7 +131,6 @@
 };
 
 std::string TimeStatsTest::inputCommand(InputCommand cmd, bool useProto) {
-    size_t index = 0;
     std::string result;
     Vector<String16> args;
 
@@ -162,7 +161,7 @@
             ALOGD("Invalid control command");
     }
 
-    EXPECT_NO_FATAL_FAILURE(mTimeStats->parseArgs(useProto, args, index, result));
+    EXPECT_NO_FATAL_FAILURE(mTimeStats->parseArgs(useProto, args, result));
     return result;
 }