commit c1498e6ed132092312e160ab00b0a2c8633611ed
author David Sodman <dsodman@google.com> Wed Sep 12 14:36:26 2018 -0700
committer David Sodman <dsodman@google.com> Thu Sep 13 17:21:37 2018 -0700
tree 1f1db8a8ae4349c7243333ccb6acb5dc55adb185
parent 78bc0453718d2755bc64e34b9157095d01a156ad

SF: Use getVisibleLayers... in doComposeSurfaces

in b/114101122, it is discovered that there is a problem
in indexing the SF mCompositionInfo by displayId because
there are multiple displays that have the same id (-1).

This change uses getVisibleLayersSortedByZ in doComposeSurfaces
until we can fix the indexing of mCompositionInfo.

Bug: 114101122
Test: run cts -m CtsViewTestCases, CtsMediaTestCases

Change-Id: I90adb957c183400c396f25fa9583b668e1da8417

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 9537ccc..f17710e 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -3218,30 +3218,29 @@
     ALOGV("Rendering client layers");
     const ui::Transform& displayTransform = display->getTransform();
     bool firstLayer = true;
-    for (auto& compositionInfo : getBE().mCompositionInfo[displayId]) {
-        const Region bounds(display->bounds());
+    for (auto& layer : display->getVisibleLayersSortedByZ()) {
         const Region clip(bounds.intersect(
-                displayTransform.transform(compositionInfo.layer->mLayer->visibleRegion)));
-        ALOGV("Layer: %s", compositionInfo.layerName.c_str());
+                displayTransform.transform(layer->visibleRegion)));
+        ALOGV("Layer: %s", layer->getName().string());
+        ALOGV("  Composition type: %s", to_string(layer->getCompositionType(displayId)).c_str());
         if (!clip.isEmpty()) {
-            switch (compositionInfo.compositionType) {
+            switch (layer->getCompositionType(displayId)) {
                 case HWC2::Composition::Cursor:
                 case HWC2::Composition::Device:
                 case HWC2::Composition::Sideband:
                 case HWC2::Composition::SolidColor: {
-                    const Layer::State& state(compositionInfo.layer->mLayer->getDrawingState());
-                    const bool opaque = compositionInfo.layer->mLayer->isOpaque(state) &&
-                                        compositionInfo.layer->mLayer->getAlpha() == 1.0f;
-                    if (compositionInfo.hwc.clearClientTarget && !firstLayer && opaque &&
-                            hasClientComposition) {
+                    const Layer::State& state(layer->getDrawingState());
+                    if (layer->getClearClientTarget(displayId) && !firstLayer &&
+                        layer->isOpaque(state) && (layer->getAlpha() == 1.0f) &&
+                        hasClientComposition) {
                         // never clear the very first layer since we're
                         // guaranteed the FB is already cleared
-                        compositionInfo.layer->clear(getRenderEngine());
+                        layer->clearWithOpenGL(renderArea);
                     }
                     break;
                 }
                 case HWC2::Composition::Client: {
-                    compositionInfo.layer->mLayer->draw(renderArea, clip);
+                    layer->draw(renderArea, clip);
                     break;
                 }
                 default: