commit b81767912e9101f8522b4393beaf3360dff3ec07
author Steven Moreland <smoreland@google.com> Tue Jun 22 20:29:21 2021 +0000
committer Steven Moreland <smoreland@google.com> Thu Jun 24 18:07:45 2021 +0000
tree 06d6a785b3ebf1cdbe50eb8e63756e12f0ea9777
parent 936fc19aa0ca565dc0903c577658676ad76575b7

libbinder: RPC flake mode

Add mode to make flakes more visible, for debugging.

Fixes: 190828148
Test: run w/ binderLibTest and the fuzzer for a bit (no tests
  fail - some tests can be made to fail by increasing the delay,
  but this is because some of the tests, namely OnewayStressTest,
  relies on all operations completing within a certain timeframe)
Change-Id: I3b38ff55ffc56410db585fa02e57ac0271da2b5d

libs/binder/RpcSession.cpp

diff --git a/libs/binder/RpcSession.cpp b/libs/binder/RpcSession.cpp
index a759ae3..c1154b8 100644
--- a/libs/binder/RpcSession.cpp
+++ b/libs/binder/RpcSession.cpp
@@ -198,6 +198,8 @@
     uint8_t* buffer = reinterpret_cast<uint8_t*>(data);
     uint8_t* end = buffer + size;
 
+    MAYBE_WAIT_IN_FLAKE_MODE;
+
     status_t status;
     while ((status = triggerablePollRead(fd)) == OK) {
         ssize_t readSize = TEMP_FAILURE_RETRY(recv(fd.get(), buffer, end - buffer, MSG_NOSIGNAL));