commit b7246642bee083cbd415ce731c14955735fafcee
author Elie Kheirallah <khei@google.com> Tue May 03 18:01:43 2022 +0000
committer Elie Kheirallah <khei@google.com> Tue May 03 18:18:47 2022 +0000
tree 0e713498ecf8f0b93e94da1b7289eb30d075008f
parent 27590051170905e2d1792e8958d3a6b72e47acf5

Removed unnecessary check. Replaced EXPECT_TRUE with EXPECT_NE.

Test: binderLibTest
Change-Id: I8332dcd17a1e9ee66db6324f9c40cfc72468e279

libs/binder/tests/binderLibTest.cpp

diff --git a/libs/binder/tests/binderLibTest.cpp b/libs/binder/tests/binderLibTest.cpp
index b1e17b7..57a1fda 100644
--- a/libs/binder/tests/binderLibTest.cpp
+++ b/libs/binder/tests/binderLibTest.cpp
@@ -247,13 +247,11 @@
         {
             int32_t id;
             Parcel data, reply;
-            sp<IBinder> binder;
 
             EXPECT_THAT(m_server->transact(code, data, &reply), StatusEq(NO_ERROR));
 
-            EXPECT_FALSE(binder != nullptr);
-            binder = reply.readStrongBinder();
-            EXPECT_TRUE(binder != nullptr);
+            sp<IBinder> binder = reply.readStrongBinder();
+            EXPECT_NE(nullptr, binder);
             EXPECT_THAT(reply.readInt32(&id), StatusEq(NO_ERROR));
             if (idPtr)
                 *idPtr = id;