commit b6a1e7eb34980400bdbabcab756c5a244b1f525b
author Steven Moreland <smoreland@google.com> Wed May 05 23:36:46 2021 +0000
committer Steven Moreland <smoreland@google.com> Wed May 05 23:41:04 2021 +0000
tree 4f681c34a0ecc1747f15d979c449c462c5686638
parent e8393349fe438e65babd434f0a37c976ef0ff3ed

libbinder: remove RpcState deadlock debug logs

'dump' internally takes a lock, and there were two calls to it here
which would actually deadlock. Simply removing them to move fuzzer
forward.

Bug: 182938024
Test: fuzzer
Change-Id: Ic07193955f0794fd1fc11d7e89c65b469a43323c

libs/binder/RpcState.cpp

diff --git a/libs/binder/RpcState.cpp b/libs/binder/RpcState.cpp
index 976351c..20fdbfe 100644
--- a/libs/binder/RpcState.cpp
+++ b/libs/binder/RpcState.cpp
@@ -511,7 +511,6 @@
         auto it = mNodeForAddress.find(addr);
         if (it == mNodeForAddress.end()) {
             ALOGE("Unknown binder address %s.", addr.toString().c_str());
-            dump();
             replyStatus = BAD_VALUE;
         } else {
             target = it->second.binder.promote();
@@ -707,7 +706,6 @@
     auto it = mNodeForAddress.find(addr);
     if (it == mNodeForAddress.end()) {
         ALOGE("Unknown binder address %s for dec strong.", addr.toString().c_str());
-        dump();
         return OK;
     }