commit b55ddfee6733fa688ce7969b0aa522bc9deeb0d7
author Manoj Gupta <manojgupta@google.com> Wed Aug 23 08:22:03 2017 +0000
committer android-build-merger <android-build-merger@google.com> Wed Aug 23 08:22:03 2017 +0000
tree 2d8f73afc2d915fe63f82433f96d9fdb29843e35
parent eadd69b878628006dc1d09e350b739b67bb37056
parent ac18e8a9b0916e38acccaff3ce0967d3fd2a2cb5

Merge "Fix static analyzer warnings." am: 5b843179ff am: 96e489dc8d am: 369b2032f5 am: 97f05421ef
am: ac18e8a9b0

Change-Id: Id71496109da78a92803c2798bcc4c55411dc4fee

libs/binder/Value.cpp

diff --git a/libs/binder/Value.cpp b/libs/binder/Value.cpp
index fd1dfd5..85cd739 100644
--- a/libs/binder/Value.cpp
+++ b/libs/binder/Value.cpp
@@ -182,10 +182,12 @@
 
 Value& Value::operator=(const Value& rhs)
 {
-    delete mContent;
-    mContent = rhs.mContent
-        ? rhs.mContent->clone()
-        : NULL;
+    if (this != &rhs) {
+        delete mContent;
+        mContent = rhs.mContent
+            ? rhs.mContent->clone()
+            : NULL;
+    }
     return *this;
 }