commit b524c931d361d908278a18480878a8b6c4d36cd8
author Anders Frostad Pedersen <anders.pedersen@arm.corp-partner.google.com> Sat Aug 31 00:47:20 2019 +0200
committer Courtney Goeltzenleuchter <courtneygo@google.com> Tue Sep 03 13:38:10 2019 -0600
tree 4c6914f51de760254f014f13b0e36bc573158c45
parent 5488416631c0a23ccef61975860f2755e8e8d834

eglSwapBuffersWithDamageKHR robustness

Add some additional checking for negative and NULL rects.

Bug: 140252008
Change-Id: I932d5115c2c8da5d824e414c807f59a4a1a73e5b
Test: Manual
(cherry picked from commit b7dc63f26208097f52456e22fe40baa540e37edc)

opengl/libs/EGL/egl_platform_entries.cpp

diff --git a/opengl/libs/EGL/egl_platform_entries.cpp b/opengl/libs/EGL/egl_platform_entries.cpp
index e996be6..d1b4a4e 100644
--- a/opengl/libs/EGL/egl_platform_entries.cpp
+++ b/opengl/libs/EGL/egl_platform_entries.cpp
@@ -1379,6 +1379,9 @@
     if (!_s.get())
         return setError(EGL_BAD_SURFACE, (EGLBoolean)EGL_FALSE);
 
+    if (n_rects < 0 || (n_rects > 0 && rects == NULL))
+        return setError(EGL_BAD_PARAMETER, (EGLBoolean)EGL_FALSE);
+
     egl_surface_t* const s = get_surface(draw);
 
     if (CC_UNLIKELY(dp->traceGpuCompletion)) {