commit b4389d9b481e9d869ee46fd23d4d098090e7d8f4
author Jayachandran C <jayachandranc@google.com> Mon Jul 08 09:46:05 2019 -0700
committer Jayachandran Chinnakkannu <jayachandranc@google.com> Wed Aug 14 17:13:34 2019 +0000
tree 9a63fb4ab6f227590802971129419a06a9d9b5bb
parent 4ede27d7bc1e0bbe8d17db3a8d850af6c1c95931

Dump HALs and enable persistent logs for radio bugreports

HALs dumps are needed to debug WFC releated issues
Persistent logs capture is needed to capture the history of logs that
captures the scenario of telephony going to bad state.

Bug: 138261934
Test: Triggered telephony dumpsys using connectivity monitor app and verified

Change-Id: I158e327d5c5a13c64e48d5711f82903d4a50b8f0

cmds/dumpstate/dumpstate.cpp

diff --git a/cmds/dumpstate/dumpstate.cpp b/cmds/dumpstate/dumpstate.cpp
index 4ac7b68..5de4077 100644
--- a/cmds/dumpstate/dumpstate.cpp
+++ b/cmds/dumpstate/dumpstate.cpp
@@ -1594,6 +1594,8 @@
 static void DumpstateRadioCommon() {
     DumpIpTablesAsRoot();
 
+    ds.AddDir(LOGPERSIST_DATA_DIR, false);
+
     if (!DropRootUser()) {
         return;
     }
@@ -1604,6 +1606,7 @@
     DoKmsg();
     DumpIpAddrAndRules();
     dump_route_tables();
+    DumpHals();
 
     RunDumpsys("NETWORK DIAGNOSTICS", {"connectivity", "--diag"},
                CommandOptions::WithTimeout(10).Build());
@@ -1673,8 +1676,6 @@
     RunDumpsys("DUMPSYS", {"wifi"}, CommandOptions::WithTimeout(90).Build(),
                SEC_TO_MSEC(10));
 
-    DumpHals();
-
     printf("========================================================\n");
     printf("== dumpstate: done (id %d)\n", ds.id_);
     printf("========================================================\n");